Add legacy MD5 checksum validation#6790
Conversation
simonelbaz
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
|
The PR needs some permission to pass the failed check. Thanks for any review & help. |
|
@simonelbaz , Will this supersede #6356 ? |
Yes, it will. |
|
@simonelbaz , Your second commit appears to have the wrong DCO. Please correct. |
simonelbaz
force-pushed
the
md5checksum-2
branch
2 times, most recently
from
d9de5b9 to
19c29eb
Compare
dlvenable
left a comment
dlvenable
left a comment
There was a problem hiding this comment.
Thanks for the contribution @simonelbaz !
|
@dlvenable : thanks for your feedback. Is it slated to be merged to main branch pls? |
|
@simonelbaz , There are merge conflicts to merge to |
Signed-off-by: Simon ELBAZ <elbazsimon9@gmail.com>
Signed-off-by: Simon ELBAZ <elbazsimon9@gmail.com>
Signed-off-by: Simon ELBAZ <elbazsimon9@gmail.com>
@dlvenable : rebase done |
|
@dlvenable : is there any action I need to perform in order to get the PR merged into main branch ? thanks for your feedback. |
2 participants
Description
Some S3 compatible storages still use legacy MD5 checksum validation.
With this patch, it will be possible to activate MD5 algorithm (optional).
Issues Resolved
Resolves #6780 , #6340
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.